Relax response top-level root validator #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test that checks a `Response` can be initialized with "null" values for the "required" top-level fields, while still raising a `ValidationError` if the "required" top-level fields are left out.
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
==========================================
+ Coverage 92.74% 92.77% +0.03%
==========================================
Files 67 67
Lines 3763 3765 +2
==========================================
+ Hits 3490 3493 +3
+ Misses 273 272 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Just FYI you might need to change the validator for the |
This related mainly to the top-level fields and their presence or not, instead of validating their content, which is too strict. The exception being the top-level field `errors`. Also added a lot of EOL periods to descriptions and doc-strings.
JPBergsma
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #902.
Add test that checks a
Responsecan be initialized with "null" values for the "required" top-level fields, while still raising aValidationErrorif the "required" top-level fields are left out.Note: See the issue to discuss whether this fix should be implemented or not - this PR is simply here to be able to fix the issue if we agree that it is an issue and currently violates the specification.