Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax response top-level root validator #903

Merged
merged 3 commits into from
Aug 11, 2021
Merged

Relax response top-level root validator #903

merged 3 commits into from
Aug 11, 2021

Commits on Aug 10, 2021

  1. Relax response top-level root validator 

    Add test that checks a `Response` can be initialized with "null" values
for the "required" top-level fields, while still raising a
`ValidationError` if the "required" top-level fields are left out.
    @CasperWA
    CasperWA committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    bd59b5c View commit details
    Browse the repository at this point in the history

  2. Relax validations for general response models 

    This related mainly to the top-level fields and their presence or not,
instead of validating their content, which is too strict.
The exception being the top-level field `errors`.

Also added a lot of EOL periods to descriptions and doc-strings.
    @CasperWA
    CasperWA committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    34772b7 View commit details
    Browse the repository at this point in the history

  3. Fix new test

    @CasperWA
    CasperWA committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    6db2727 View commit details
    Browse the repository at this point in the history