Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Undefined property warning for request filter argument #261

Merged
merged 1 commit into from
May 3, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented May 1, 2022

Description of the Change

Recently in #257 (merged) was added a mistype, the arguments for sophi_request_result in Auth::request_access_token() were copied from the same filter in Request:request().

That's why each time Auth:request_access_token() is called, it produce the Warning

Closes: #260

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

@cadic cadic requested a review from jeffpaul May 1, 2022 17:12
@cadic cadic self-assigned this May 1, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jeffpaul jeffpaul added this to the 1.0.14 milestone May 2, 2022
@jeffpaul jeffpaul requested review from oscarssanchez and felipeelia and removed request for jeffpaul May 2, 2022 13:13
@jeffpaul jeffpaul merged commit 2a72509 into develop May 3, 2022
@jeffpaul jeffpaul deleted the fix/auth-result-filter-warning branch May 3, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: Undefined property: SophiWP\SiteAutomation\Auth::$api_url
2 participants