Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitpod.yml #114

Merged
merged 1 commit into from
Jan 23, 2022
Merged

Add .gitpod.yml #114

merged 1 commit into from
Jan 23, 2022

Conversation

TiagoCavalcante
Copy link
Contributor

To test this:
https://gitpod.io/#https://github.com/TiagoCavalcante/mathics-core

We should add an easy-to-find mention to this, I recommend a badge in README.

github:
prebuilds:
addComment: false
addBadge: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a "Review in GitPod" badge to PRs.

@mmatera
Copy link
Contributor

mmatera commented Jan 14, 2022

I like this!

Copy link
Member

@rocky rocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I am not sure if I trust gitpod right now with my permissions, but that is up to an individual to decide.

@rocky
Copy link
Member

rocky commented Jan 23, 2022

After mulling this over a bit and after looking over gitpod, okay, let's try it! I will mention though that I personally do not want to expose myself to allowing gitpod write access from my account. It is not that I don't trust gitpod, but its more about being concerned about those who may use gitpod as a surface to attack.

So what that said, let's try it.

@rocky rocky merged commit ae97d3a into Mathics3:master Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants