Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a statSync to get the file mtime and set LastModified #38

Merged
merged 2 commits into from
May 20, 2017

Conversation

stujo
Copy link
Contributor

@stujo stujo commented Mar 10, 2017

#37 Attempting To Address

@MathieuLoutre MathieuLoutre merged commit 29bf725 into MathieuLoutre:master May 20, 2017
@MathieuLoutre
Copy link
Owner

Great solution. Thanks for this and sorry it took so long to review and merge this.

@AllanHodkinson
Copy link

Hi,
Pretty sure there is a bug in this code for the getObject function:
If the requested file doesn't exist then
var stat = fs.statSync(path);
will throw an untrapped error.
The fix is to move this line into the if (!err) statement.

I can do you a fix if you like but it's probably quicker to do it yourselves.
Thanks,
Allan

@MathieuLoutre
Copy link
Owner

Thanks Allan, not sure how I missed that but good spot! The fix should be in and published in 2.5.1 if I didn't mess anything up this time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants