Fix identities authenticate crash
#150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure it makes sense to have this in the CLI. The whole point is to share the functionality between CLI, desktop and mobile. This the library can provide the necessary platform detection. |
|
I can apply the fix to |
…browser If it fails to find a browser with `ENOENT` then it will just ignore that. All other errors will still be thrown. [ci skip]
tegefaulkes
force-pushed
the
feature-authenticate-fix
branch
from
f377d39
to
2bbad73
Compare
|
Alright, I've fixed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses crashing when using
identities authenticateif it fails to open a browser.Issues Fixed
identities authenticatefails without a desktop enviroment #76Tasks
Browserutility function fromPolykeyintoPolykey-CLI.Browserthrow when failing to spawn browser rather than crashing the process.Final checklist