Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: seed nodes crashing from ending connections #494

Closed
tegefaulkes opened this issue Nov 10, 2022 · 2 comments
Closed

fix: seed nodes crashing from ending connections #494

tegefaulkes opened this issue Nov 10, 2022 · 2 comments
Assignees
Labels
development Standard development r&d:polykey:core activity 3 Peer to Peer Federated Hierarchy

Comments

@tegefaulkes
Copy link
Contributor

Specification

Due to recent changes the seed nodes have started crashing. The cause of the crash seems to be when a node connection to the seed node shuts down. So far I've seen it when running the testnetConnection.test.ts tests, the first run of the test succeeds and the 2nd tends to fail due to the seed node crashing. So far as I can tell, the clean up stage of the test where we kill the agent process with a SIGINT signal is when it happens.

On the seed node side of things we see the following error.

{
    "type": "TypeError",
    "data": {
        "message": "Cannot read properties of null (reading 'finishShutdown')",
        "stack": "TypeError: Cannot read properties of null (reading 'finishShutdown')\n    at JSStreamSocket.finishShutdown (node:internal/js_stream_socket:160:12)\n    at Immediate.<anonymous> (node:internal/js_stream_socket:234:12)\n    at processImmediate (node:internal/timers:466:21)"
    }
}

A cursory search found this issue nodejs/node#35695 which indicates this may be a bug in nodes HTTP implementation. Further investigation is needed.

Additional context

Tasks

  1. Find the core cause of the problem
  2. fix the problem
@tegefaulkes tegefaulkes added the development Standard development label Nov 10, 2022
@CMCDragonkai CMCDragonkai added the r&d:polykey:core activity 3 Peer to Peer Federated Hierarchy label Jul 9, 2023
@CMCDragonkai
Copy link
Member

Need to review this as part of #551.

@tegefaulkes
Copy link
Contributor Author

This Issue relates to the old test-net deployment and old network stack.

After converting to js-quic this is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development r&d:polykey:core activity 3 Peer to Peer Federated Hierarchy
Development

No branches or pull requests

2 participants