Agent RPC migration

[tegefaulkes]

Specification

Similar to #509 but separate enough to be it's own issue/PR. We need to migrate the agent-agent communication to make use of the new agnostic RPC and quic system being developed. Thankfully there are much fewer agent-agent handlers we need to migrate but they tend to be more complicated.

Some complications that need to be addresses is the the git pull and clone logic. They need to be updated to make use of the raw streams. The raw stream feature may need to be expanded to support this.

This is currently blocked by the quic system.

Part of migrating the agent, the network and GRPC domains should be removed. Any code still depending on them need to be updated to the new systems.

We need to spec out how we want to handle the common elements between the client and agent RPC. They will end up sharing middleware, message data structure and metadata structure. These things should be kept in a common location but the RPC domain isn't appropriate.

Additional context

• Related Client RPC migration #509
• Related Transport Agnostic RPC #249
• Related Migrate from GRPC to JSON RPC (with binary variant for higher performance) #495
• Related Make rpc handlers abstract arrow function properties. js-rpc#5
• Related Add timeout support to the Agnostic RPC system #510

Tasks

1. migrate handlers to the new RPC system
2. migrate tests
3. update RPC usage within the code
4. Remove any old GRPC or network code. GRPC domain should be fully removed at this point. Not sure about network.

[tegefaulkes]

This one will take much less time compared to the client migration since there are much less handlers to migrate. At the same time we need to work out some things with the git handlers. They need to be implemented with the raw handlers and possibly need some features added to it to support middlware.

For timing this is blocked by the quic changes but doesn't strictly require them to get started, just to run it.

[tegefaulkes]

There are going to be common elements used between the agent RPC and the client RPC. This stuff should be kept to a common domain. The specifics of this need to be worked out during this issue.

#513 (comment)

[tegefaulkes]

When migrating the agent handlers, we need to update them to use the CTX and timeouts.

[CMCDragonkai]

Since closing #466:

Very important to review also the client RPC to ensure deadlines are also applied too.

On the server side, handlers that are asynchronous should have a deadline propagated into asynchronous subcalls.

[tegefaulkes]

There are a few stages to this one.

1. Migrate the agent handlers to the agnostic RPC.
2. Convert any handlers to use the timeout system if needed, Anything that is long running, async or canncellable needs to be updated.
3. Replace the Proxy/GRPC server/client with js-quic. This will be a major change to the NodeConnectionManager.
   A. NodeConnectionManager needs to use js-quic and agnostic RPC clients.
   B. PolykeyAgent needs to use the js-quic/agnostic RPC server.
4. Gut any Proxy, GRPC and utp dependencies and code.

[tegefaulkes]

I should possibly do the following issues while working on this.

• RPC Raw Streams for Binary Data js-rpc#2
• Make rpc handlers abstract arrow function properties. js-rpc#5
• Pagination Deployment to Service Handlers and CLI Commands and Domain Collections #237

[CMCDragonkai]

Shouldn't this have been part of #495?

---

Ah yes it is.