-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessing Vault after cloning fails #518
Comments
A few things to try here. Check my existing issues in swc: https://github.com/swc-project/swc/issues/created_by/cmcdragonkai And update swc to the latest to see if it solves the problem. And then drill down to see if it can be fixed, or a new upstream issue must be created. |
You can monkey patch the By checking the |
It does not look like one of the existing issues in swc that I posted, so it could be a new upstream bug. But first thing to do is update SWC to latest then re-run. |
Can you confirm @tegefaulkes and close if done. |
I just did some manual testing and we can see that it is all working now. If I recall, previously the problem was that after cloning accessing the secret would throw. we needed to restart the node to access the secret. Reading over the issue recall this being a problem with how we used the I'm going to close this issue. |
Describe the bug
During the process of creating the Agent-Agent interaction tutorial I found a bug. Right after cloning a vault from a remote agent the local agent would throw an error if you tried to access the newly cloned vault.
The error is as follows.
Tracking down this error it seems to be coming from the
@ready
decorator for the vaultInternal when accessing the vault withVaultInternal.readF()
.This only happens when running the commands with
npm run polykey -- ...
, Doing the same withnode dist/bin/polykey
does not result in any errors.Since the
npm run polykey
is compiling polykey withts-node
and ultimatelyswc
, and the fact we've had problems withswc
and decorators before. It's safe the assume this is aswc
problem.To Reproduce
I'm assuming you know how to set up nodes and get them to communicate so I'm skimming over the initial steps here. If not, use the guide in #515 to re-create this.
npm run polykey -- agent start ....
someVault
onNodeB
and add a secretNodeA
clone a vault fromNodeA
withnpm run polykey -- --node-path tmp/nodeA vaults clone <NodeBID> someVault
npm run polykey -- --node-path tmp/nodeA secrets list someVault
. This should end up throwing the error onNodeA
Expected behaviour
This should result in listing the secret in the vault.
Platform (please complete the following information)
Additional context
The text was updated successfully, but these errors were encountered: