Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Auth Timeout is too low #588

Closed
addievo opened this issue Oct 17, 2023 · 5 comments · Fixed by #589
Closed

GitHub Auth Timeout is too low #588

addievo opened this issue Oct 17, 2023 · 5 comments · Fixed by #589
Labels
bug Something isn't working

Comments

@addievo
Copy link
Contributor

addievo commented Oct 17, 2023

Describe the bug

GitHub auth times out before completion due to timeout being too low

To Reproduce

  1. Try claiming github identity.
  2. Wait
  3. It aborts

Expected behavior

Should not abort unexpectedly.

Platform (please complete the following information)

  • Version: CLI
@CMCDragonkai
Copy link
Member

This will require the new RPC release. @tegefaulkes what's the new version for this?

@tegefaulkes
Copy link
Contributor

New release is @matrixai/rpc 0.2.5

@tegefaulkes
Copy link
Contributor

@CMCDragonkai found that the identities claim times out to quickly. This was fixed right? I'm going to re-open this issue until it's confirmed again.

It's only considered complete if the CLI command identities claim can be completed without feeling rushed.

@tegefaulkes tegefaulkes reopened this Jan 30, 2024
@CMCDragonkai
Copy link
Member

I think this was confused, the #589 certainly didn't fix it. MatrixAI/Polykey-CLI#49 was closed and #625 is still part of solving this.

@amydevs
Copy link
Member

amydevs commented Feb 22, 2024

This regression has been fixed. The changes to the MDNS timeout, where the a client's shorter timeout would override that of a server had broken it. I have set the timeout to be equal on the client to be 120000ms (2 minutes). Commit: MatrixAI/Polykey-CLI@35d2cf1

@amydevs amydevs closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
4 participants