Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of ctx when for identities Provider.authenticate Interface #625

Open
amydevs opened this issue Nov 10, 2023 · 0 comments
Open

Use of ctx when for identities Provider.authenticate Interface #625

amydevs opened this issue Nov 10, 2023 · 0 comments
Labels
development Standard development

Comments

@amydevs
Copy link
Member

amydevs commented Nov 10, 2023 •
edited

Specification

Currently Provider.authenticate has number timeout parameter. This is a leftover from how the identities domain was initially implemented. This will need to be changed to a ctx to be inline with how timeouts are now handled in the rest of PK.

Additional context

This will have some implications detailed here:

MatrixAI/Polykey-CLI#49

Tasks

  1. Change Provider.authenticate to use ctx
  2. Update GitHubProvider to match
  3. Update related identities tests
@amydevs amydevs added the development Standard development label Nov 10, 2023
@tegefaulkes tegefaulkes mentioned this issue Dec 13, 2023
Closed
@CMCDragonkai CMCDragonkai mentioned this issue Jan 30, 2024
Closed
@tegefaulkes tegefaulkes changed the title Use of ctx when for identities Provider.authenticate Interface Use of ctx when for identities Provider.authenticate Interface Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
development Standard development
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amydevs