Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodesListConnections handler is randomly mapping IP addresses as IPv6 mapped IPv4 #614

Closed
addievo opened this issue Oct 31, 2023 · 2 comments · Fixed by #624
Closed

NodesListConnections handler is randomly mapping IP addresses as IPv6 mapped IPv4 #614

addievo opened this issue Oct 31, 2023 · 2 comments · Fixed by #624
Assignees
@tegefaulkes @amydevs
Labels
development Standard development r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices

Comments

@addievo
Copy link
Contributor

addievo commented Oct 31, 2023

Specification

Whilst testing Polykey CLI's nodes getall or nodes connections, the IP address is getting listed as IPv6 mapped IPv4, this is inaccurate as all the testing has been performed on IPv4 addresses only.

This behaviour needs to be investigated and consequently resolved.

Tasks

  1. Investigate where this occurs.
  2. Investigate why this occurs.
  3. Fix mapping.
@addievo addievo added the development Standard development label Oct 31, 2023
@addievo addievo mentioned this issue Oct 31, 2023
Closed
4 tasks
@CMCDragonkai CMCDragonkai mentioned this issue Nov 5, 2023
Closed
This was referenced Nov 13, 2023
Closed
Merged
@tegefaulkes
Copy link
Contributor

Looking into this. If the QUICSocket is dual stack and a reverse connection is handled by the NodeConnectionManager, the resulting Host added to the NodeGraph is the IPV6 mapped IPv4 address.

It's a simple fix to convert this back to the IPv4 form before putting it into the NodeGraph. But I'm unsure if QUIC is mean to be converting these under the hood so we never deal with the mapped form directly? @CMCDragonkai

@CMCDragonkai
Copy link
Member

I don't think QUIC should do anything too fancy here.

@CMCDragonkai CMCDragonkai mentioned this issue Nov 14, 2023
Closed
@CMCDragonkai CMCDragonkai added the r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tegefaulkes tegefaulkes

@amydevs amydevs

Labels
development Standard development r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: connection with ICE now gets target port from signalling node MatrixAI/Polykey
4 participants
@CMCDragonkai @tegefaulkes @addievo @amydevs