Add Peer Discovery Code

[robert-cronin]

This PR will include a PeerStore for keeping track of PeerInfo. A multicast broadcasting class for peer discovery on the same LAN and various other bug fixes (e.g. relative @ imports).

Edit: this PR now also includes a mechanism for discovering a social user via a handle (robert-cronin) and a service (github) - relates to #41

Fixes MatrixAI/TypeScript-Demo-Lib#1

[CMCDragonkai]

As a general note. This is awesome. But we need to discuss domain modelling details.

[CMCDragonkai]

Things inside bin should not be imported. Bin things should be completely independent, self-contained programs that each result in an CLI executable.

…

On 11 June 2020 12:09:35 GMT+10:00, Robbie Cronin ***@***.***> wrote: @robert-cronin commented on this pull request. > import initPolyKey from '../initPolykey' +import { actionRunner, pkLogger, PKMessageType } from '../polykey' I got stuck here, I'm not sure how to use the module level imports for this one, at the moment ***@***.***` resolves to the `src` directory. Perhaps we could have another `tsconfig path` for the bin folder? something like ***@***.***` perhaps? -- You are receiving this because your review was requested. Reply to this email directly or view it on GitHub: #40 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[CMCDragonkai]

Yea this shouldn't be in bin.

…

On 11 June 2020 12:06:53 GMT+10:00, Robbie Cronin ***@***.***> wrote: @robert-cronin commented on this pull request. > @@ -1,10 +1,12 @@ import fs from 'fs' `initPolykey` was more intended to be a function used to get a polykey instance up and running for each command called by the user. It's not exposed to the end user. It also prompts the user in case there are any things missing from polykey's config like private key or passphrase or location. We could put it in the main `polykey.ts` file perhaps? -- You are receiving this because your review was requested. Reply to this email directly or view it on GitHub: #40 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[CMCDragonkai]

• https://blog.acolyer.org/2016/02/16/capability-myths-demolished/
• https://srl.cs.jhu.edu/pubs/SRL2003-02.pdf
• https://en.wikipedia.org/wiki/Proof_of_work

[robert-cronin]

So from our previous meeting I have removed a lot of methods from the Polykey class and put them in their respective classes according to which domain model they belong to.

[CMCDragonkai]

Can you give a brief description of what was done so I know what was applied on a high level from our discussion.

[robert-cronin]

Can you give a brief description of what was done so I know what was applied on a high level from our discussion.

So the main changes are:

• Move domain model concerns to relevant classes (i.e. vault operations to Vault.ts, crypto operations to KeyManager.ts etc.)
• Added a web worker for the crypto operations (KeyManagerWorker.ts)
• Tied the starting of the multicast peer discovery server to its initialisation
• Made UDP multicast port optional environment variables
• Added ability to add more social discovery services to PeerDiscovery class

Note: I think it's probably better if I do WIP commits with good descriptions from now on and leave the squashing to the end for more clarity for the reviewer.

[CMCDragonkai]

I'd like to see more integration tests in the near future for this kind of code especially as it interacts with the network. But also all the edgecases, we'll have to plan that out.

I'm going to approve for merging so you can start synchronizing the other work.

[CMCDragonkai]

Woops I was trying the Github merge options. But I think it just left the WIP commits there. Not a big deal, but need to remember to use the squash option, not rebase option.

[CMCDragonkai]

I've rebased and squashed so the master is clean again.

[CMCDragonkai]

Delete the above branch if you don't need it again.