-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for npm publish and also reworking the cryptoworker and additional tests #23
Conversation
f42606b
to
c50c2fb
Compare
e4d8b98
to
275d851
Compare
275d851
to
1b71e9f
Compare
I think to go through the crypto code we would need to have a meeting. It would be difficult for me to review it on my own. |
I agree, there is quite a bit to go through here, let me know when is best 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main thing is to add as much fuzzing tests to the readSync/writeSync functions because they are really complex.
One way to do this is to check synchronous behaviour "bisimulation" between real fs and EFS when seeking randomly and reading randomly and writing randomly. And comparing the pre and post conditions.
Just a note to write down, page cache for read hasn't been implemented, whereas page cache has been implemented for "write then read". For read, it requires us to figure out the chunk mapping index structure because we need to keep track of "true nulls" vs nulls of convenience ("non-existent nulls").
I've added quite a few bisimulation tests that test all the way from 1-3 blocks, 1-2 rounds of read/write as well as bisimulation tests for |
Ok I'm merging this. |
This is to prepare and eventually do npm publish
Fixes #16