move code back into virtual-dom #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 800f41c on Raynos:all-in-one into * on Matt-Esch:master*. |
|
Changes Unknown when pulling 0d261da on Raynos:all-in-one into * on Matt-Esch:master*. |
|
Yes please thanks, I was getting tired of flipping aroung between repos. |
| assert.equal(rootNode.value, "") | ||
| assert.end() | ||
| }) | ||
|
|
There was a problem hiding this comment.
why was this test removed?
There was a problem hiding this comment.
difference in semantics between old h & virtual-hyperscript.
|
👏 much less |
|
There are also three more pull requests based on top of this one ( https://github.com/Raynos/virtual-dom/pulls ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that moves vtree, vdom & virtual-hyperscript back
into virtual-dom so that we can have all the issues and
communication happening in one place.
This also solves pain points with versioning.
cc @Matt-Esch