add custom element type extensions support #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
got a test? |
|
the reason i ask about the test is that i believe things will break if you don't have a value for |
|
As of the spec:
I did not add a unit test, because it would probably fail on older browsers. <!DOCTYPE html>
<html>
<head>
<title>test</title>
<script type="text/javascript" src="dist/virtual-dom.js"></script>
</head>
<body>
<script type="text/javascript">
var proto = Object.create(HTMLAnchorElement.prototype)
proto.attachedCallback = function() {
alert('WORKS')
}
document.registerElement('custom-link', {
prototype: proto,
extends: 'a'
})
var h = virtualDom.h
var tree = h('div', {}, [
h('a', { attributes: { is: 'custom-link' } }, [String('foo')])
])
document.body.appendChild(virtualDom.create(tree))
</script>
</body>
</html>It should alert WORKS. Thanks for having a look! |
|
Just saw that I get <a is="A">...</a>in some browsers. I've updated the PR |
|
the code looks good. i just wish there was some way to write a test for this. @Matt-Esch any thoughts on how to add a test for this? |
|
Anything I can do to help getting this merged? Thanks! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for custom elements extending existing HTML elements, e.g.: