Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to customize the rendering function. #213

Merged
merged 1 commit into from
Apr 15, 2015
Merged

Allows to customize the rendering function. #213

merged 1 commit into from
Apr 15, 2015

Conversation

jails
Copy link
Contributor

@jails jails commented Apr 3, 2015

After some investigation, I created a custom "vdom/create-element.js" function to catch the node creation step and to be able to perform some custom tasks. However I realized that there was a hard coded reference of the default "vdom/create-element.js" rendering function in "vdom/patch-op.js" and I didn't find a way to inject my custom rendering function.

In this PR there is a minor change which make the rendering function customizable the same way the patch function is.

Is it something acceptable ?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 97.5% when pulling 87c61fa on jails:make-rendering-customizable into 1186cdc on Matt-Esch:master.

@dylanmcdiarmid
Copy link
Contributor

👍

@Matt-Esch
Copy link
Owner

I'd love to merge this, I think it's the right way to go, but not without a test ;)

@jails
Copy link
Contributor Author

jails commented Apr 6, 2015

No big deal, just squashed the commits.
I think the tests now cover all differents use cases.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 97.5% when pulling 519fd8d on jails:make-rendering-customizable into 1dda0f6 on Matt-Esch:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants