vtree/diff: combine unhook and destroyWidget to use a single walk #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishanths
commented
Apr 14, 2018
| // - Add patch records for destroyed widgets. This is required because we | ||
| // need a DOM node reference for the destroy function. | ||
| // - Execute hooks when two nodes are identical. | ||
| function clearState(vNode, patch, index) { |
There was a problem hiding this comment.
Moved this to the bottom to make the diff less messy.
On master, travis fails currently with the following error:
ERROR: npm is known not to run on Node.js v0.12.18
You'll need to upgrade to a newer version in order to use this
version of npm. Supported versions are 4, 6, 7, 8, 9. You can find the
latest version at https://nodejs.org/
This updates .travis.yml to use the latest stable node ('node')
and all the latest LTS releases ('lts/*'). The relevant docs are at
https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#Specifying-Node.js-versions
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading this over the weekend and came across the following
TODOin clearState, which seemed like a worthwhile thing to address.However, I have no context on whether this change will result in a measurable performance improvement. I'm happy to add benchmarks, if necessary.