Remove use of .includes to better support IE
#51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the one use of `Array.prototype.includes` with `Array.prototype.indexOf`, which can be used to achieve the same thing: `x.includes(y) === x.indexOf(y) > -1`. This allows the code to work in IE11 and earlier, which do not support `.includes` I've also standardized the `browsers` targets across the `.babelrc` and `roolup.config.js` files to make them consistent.
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue identified in #49 that seems to have been first brought up in #43
This replaces the one use of
Array.prototype.includeswithArray.prototype.indexOf, which can be used to achieve the same thing:x.includes(y) === x.indexOf(y) > -1. This allows the code to work in IE11 and earlier, which do not support.includesI've also standardized the
browserstargets across the.babelrcandrollup.config.jsfiles to make them consistent, along with minor code formatting improvements.