Add OSX support #16
Merged
Add OSX support #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eSerialNumber + Add BashExecutorComponent
Add OSX column
|
This looks great, thanks. I'll review, merge, and release it as soon as I get a chance. |
|
I've merged the changes. I'm pretty busy with work at the moment but I want to add a few more OSX components before I get this release out. Shouldn't be too long. Thanks again! |
|
Hey @techtim Thanks again for this PR. I have one question for you as a Mac user. It looks to me like the serial number from "IOPlatformSerialNumber" would be a better fit for the "SystemUUID" component rather than the "ProcessorId" component. Would you agree, or am I off base here? Cheers |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 OSX parameters using new BashExecutorComponent: