-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fails to load very big constant numbers #38
Comments
Thanks for the report. Could you make a PR adding LOAD_CONST to _stack_effects so that we avoid the offending call ? Add a test and an entry in the changlog. |
Very glad to do that. I'll make it done. |
I can't reproduce the error. What python version do you use? |
I did not have time to try to reproduce but the line 34 in oparg_int = (int)PyLong_AsLong(oparg); |
@serhiy-storchaka This |
And I'm using Python 3.6.5 in Windows 10 x86_64. |
@MatthieuDartiailh Yes, you're right! I've found the way to solve this problem, a few minutes. |
I am not sure that specifying a whitelist for opcodes whose stack effect depends on its argument is a good approach. The list is not complete. It lacks following opcodes: Are there other opcodes that need a workaround besides |
#41 addresses this. |
Thanks for the ping @serhiy-storchaka . Actually I probably was in too much of a rush when reviewing the #43. |
I have extracted the fix for this issue into separate PR #44. |
Hey, I come back again and ask for your help!
When I was loading very big numbers, I got an
OverflowError
:Let's avoid performing
dis.stack_effect
when the instruction is something likeLOAD_CONST
?The text was updated successfully, but these errors were encountered: