-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.8. #41
Support Python 3.8. #41
Conversation
bytecode/instr.py
Outdated
# All opcodes whose arguments are not represented by integers have | ||
# a stack_effect indepent of their argument. | ||
arg = (self._arg if isinstance(self._arg, int) else | ||
0 if self._opcode >= _opcode.HAVE_ARGUMENT else None) | ||
return dis.stack_effect(self._opcode, arg) | ||
0 if self._opcode >= _opcode.HAVE_ARGUMENT else None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PEP8 indent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Also duplicated tests for 3.8.
674cb26
to
e5a2872
Compare
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
=========================================
Coverage ? 92.99%
=========================================
Files ? 17
Lines ? 2655
Branches ? 0
=========================================
Hits ? 2469
Misses ? 186
Partials ? 0
Continue to review full report at Codecov.
|
This was broken by #43 |
@serhiy-storchaka could you point me to the bpo discussing the changes in the bytecode that require to change the tests (for my own education) ? |
61f6731
to
608882d
Compare
This is mainly https://bugs.python.org/issue17611 (PR python/cpython#5006). |
608882d
to
29ba6aa
Compare
I will merge now and open a new issue for updating the documentation. Thanks @serhiy-storchaka |
No description provided.