Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note ENV vars In README #50

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Conversation

bcomnes
Copy link
Contributor

@bcomnes bcomnes commented Mar 31, 2022

Add a small mention about ENV var support. Thank you!

Add a small mention about ENV var support. Thank you!
@perrin4869
Copy link
Collaborator

This is only true when using postgres though. This lib also supports mssql and MySQL, and these environment variables don't work there. Maybe those clients support other environmental variables...

@bcomnes
Copy link
Contributor Author

bcomnes commented Mar 31, 2022

though this may vary with your driver.

That's what the caveat was for. Do you want me to add links to those drivers too?

@perrin4869 perrin4869 merged commit 3703883 into MattiLehtinen:master Apr 1, 2022
@perrin4869
Copy link
Collaborator

Thanks!

@coveralls
Copy link

coveralls commented Apr 1, 2022

Pull Request Test Coverage Report for Build 2072719316

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 91.768%

Totals Coverage Status
Change from base Build 2055868673: -0.7%
Covered Lines: 467
Relevant Lines: 495

💛 - Coveralls

@bcomnes bcomnes deleted the patch-1 branch April 1, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants