This repository has been archived by the owner on Apr 23, 2020. It is now read-only.
Make Watai compatible with Node v0.10 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good. I'll rebase and merge. Thanks! :) |
Since node v0.9.6, basename and extname ignore trailing slashes.
…ng suite in tests.
The condition of `should not do anything if passed empty options` test is inverted to prevent having an error code returned due to test failure.
The condition of `should not do anything if passed empty options` test is inverted to prevent having an error code returned due to test failure
Pessimistic approach, we'll see what happens with Node updates (not tested on v0.11, yet saying it won't work, to at least warn users that it's ntested)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path.basename's argument.SucceedingSuitein test's resources to ensure having a succeeding suite in tests which is not internet dependent.SucceedingSuiteinstead ofFailingSuitefor safety.