🎊 Feature display images #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional argument to pass get params and such.. Needed to limit and sort the list of posts from firebase itself. Some params (like orderBy) need to be json formatted, funny.
- Save timestamps in firebase - Save created_at date in firebase - Add firebase to response for debugging
- Read the images from firebase maybe with the front end directly - The list of posts grows downward with the most recent post at the top - Uploaded image must be visible within 2 seconds (almost instant, yay!) Fixes #7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new feature will display the actual uploaded image (in real time).
Firebase is used to read the files and uses sockets to push directly to the end user.
So.. If you have your browser open and someone will upload an image, you'll see it as soon it has been saved in firebase (almost instant);
Closes #7