Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mc 9812 Update endpoints for profile search #60

Merged
merged 5 commits into from
May 9, 2022

Conversation

pjmonks
Copy link
Contributor

@pjmonks pjmonks commented May 4, 2022

Add endpoints to support searching with profiles:

  1. Search entire catalogue and return a given profile field set
  2. Search within a particular catalogue item and return a given profile field set
  3. Get definition of a profile without requiring a catalogue item

@@ -120,6 +120,27 @@ export class MdmProfileResource extends MdmResource {
return this.simpleGet(url, query, options);
}

/**
* `HTTP GET` - Gets a profile definition for a namespace/name. This is similar to a full profile but
* without any assigned values or mapped to a catalogue item.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused by this sentence. Do you mean, "... or being mapped to a catalogue item"?

Copy link
Contributor

@abwilson23 abwilson23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just a minor comment about a comment that I found confusing. Happy for you to ignore if not important. ✅

@pjmonks pjmonks merged commit 3bfa822 into develop May 9, 2022
@pjmonks pjmonks deleted the feature/mc-9812 branch May 9, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants