-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#65 - Reorganise code files in mdm-resources #67
Conversation
Also reconfigure the build pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new organisation is much easier to navigate and reflects the structure of the postman collection, which is great.
You could maybe update the README file with instructions on running pr-checks.
* Include much more detail * Explain new npm commands available
@aaronforshaw I've updated the README as recommended, and filled in a lot more detail for it as a result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Resolves #65
Re-organises all the files in the
mdm-resources
repo so that the layout more closely matches that in the Postman API documentation - though there may be some slight differences.Everything still works in
mdm-ui
since the main entry point -src/index.ts
- has been updated to export all types correctly, andmdm-ui
references everything via the entry point.Also updated some of the npm commands:
clean
is only required now due to including theshx
package - no longer need separate clear commands for Unix and Windows OSesbuild
commands are defined by their emitted outputs - es5, es6 an es2015pr-checks
added to run before submitting a PR in GitHub, ensuring the tasks pass before Jenkins runs them