Refactored existing tests, added a ton, fixed false positives, etc. #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmervine
force-pushed
the
jmervine-integration-tests
branch
from
57a2b94
to
858a78c
Compare
|
Bah. Travis issue. I'll figure it out tomorrow. Might be removing the paths from the call. |
jmervine
changed the title
|
@jmervine want me to merge it? Also email me about integrity.js |
|
this looks great BTW |
jmervine
added a commit
that referenced
this pull request
Nov 23, 2015
Refactored existing tests, added a ton, fixed false positives, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jdorfman I took the previous headers tests, refactored and including tests against SRI as well. These all hit the CDN and therefore are true integration tests. I would actually like to run these regularly as monitoring (note to self).
These can be merged to develop whenever and go out with the next release.
Update
This branch basically turned in to a total refactor of all tests. I added individual tests for every page and fixed a ton false positives. I've much happier with our coverage now.