tests: decrease mocha's timeout #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
develop-xmr-tests-timeout
branch
from
1300b86
to
e83eca5
Compare
XhmikosR
force-pushed
the
develop-xmr-tests-timeout
branch
from
e83eca5
to
8b0e609
Compare
XhmikosR
changed the title
XhmikosR
changed the title
XhmikosR
force-pushed
the
develop-xmr-tests-timeout
branch
from
95d1d1f
to
61a51ec
Compare
jmervine
approved these changes
Jul 13, 2018
test/404_test.js
Outdated
| @@ -18,7 +18,8 @@ describe('404', () => { | |||
| done(); | |||
| }); | |||
|
|
|||
| it('valid html', (done) => { | |||
| it('valid html', function(done) { | |||
| this.timeout(5000); | |||
There was a problem hiding this comment.
I'd pull the 5000 out in to a variable set in test_helpers.js, but I won't block on it.
There was a problem hiding this comment.
All right, I'll try to do it tomorrow.
When we expect tests to take longer, set the timeout to 5 seconds explicitly. Otherwise use a 3 second timeout.
XhmikosR
force-pushed
the
develop-xmr-tests-timeout
branch
from
1fd54df
to
8d51a1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we expect tests to take longer, set the timeout to 5 seconds explicitly. Otherwise use a 3 second timeout.
@jmervine: this might need to be tweaked a little more, but from my tests, it seems 5 seconds is enough.
Fixes #1173.