#122: added immutable pass of stored array

MaxGoryunov · Oct 5, 2021 · 73d9dba · 73d9dba
1 parent 0a8dd4c
commit 73d9dba
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/ArrayAddingIterator.php b/src/ArrayAddingIterator.php
@@ -34,13 +34,9 @@ public function __construct(
      */
     public function from(Iterator $source): AddingIterator
     {
-        /**
-         * @todo #83:20min Current approach mutates existing object. If it is
-         *  not reassigned but instead passed to some method variable which
-         *  holds a reference to this object with be in an invalid state.
-         */
-        $this->added[$source->key()] ??= $source->current();
-        return new self($this->added);
+        $updated = $this->added;
+        $updated[$source->key()] ??= $source->current();
+        return new self($updated);
     }
 
     /**