Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArrayAddingIterator.php:38-40: Current approach mutates... #122

Closed
0pdd opened this issue Sep 18, 2021 · 1 comment
Closed

ArrayAddingIterator.php:38-40: Current approach mutates... #122

0pdd opened this issue Sep 18, 2021 · 1 comment
Assignees
@MaxGoryunov
Labels
bug Something isn't working

Comments

@0pdd
Copy link
Collaborator

0pdd commented Sep 18, 2021

The puzzle 83-8a90ae8d from #83 has to be resolved:

saving-iterator/src/ArrayAddingIterator.php

Lines 38 to 40 in d9297f1

* @todo #83:20min Current approach mutates existing object. If it is
* not reassigned but instead passed to some method variable which
* holds a reference to this object with be in an invalid state.

The puzzle was created by Max Goryunov on 24-Aug-21.

Estimate: 20 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd 0pdd added the bug Something isn't working label Sep 18, 2021
@MaxGoryunov MaxGoryunov self-assigned this Sep 18, 2021
MaxGoryunov added a commit that referenced this issue Oct 5, 2021
@MaxGoryunov
#122: added immutable pass of stored array
73d9dba
@MaxGoryunov MaxGoryunov mentioned this issue Oct 29, 2021
Merged
MaxGoryunov added a commit that referenced this issue Oct 29, 2021
@MaxGoryunov
#122: rewritten 'from' method to reduce number of used variables
7c593b7
@0pdd 0pdd closed this as completed Nov 2, 2021
@0pdd
Copy link
Collaborator Author

0pdd commented Nov 2, 2021

The puzzle 83-8a90ae8d has disappeared from the source code, that's why I closed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaxGoryunov MaxGoryunov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0pdd @MaxGoryunov