Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto merge PRs to DT #245

Closed
2 of 3 tasks
Maxim-Mazurok opened this issue Jun 18, 2020 · 2 comments · Fixed by #349
Closed
2 of 3 tasks

Auto merge PRs to DT #245

Maxim-Mazurok opened this issue Jun 18, 2020 · 2 comments · Fixed by #349
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Maxim-Mazurok
Copy link
Owner

Maxim-Mazurok commented Jun 18, 2020

As per conversation with @orta:

DT merge-bot logic is here: https://github.com/DefinitelyTyped/dt-mergebot

if you arbitrarily change a single test file you can get it easier to auto-merge

You'll need the bot to also say "OK to merge" or something like that after CI (~1 hr) too
Perhaps make an issue on https://github.com/DefinitelyTyped/dt-mergebot/issues about asking for a way to declare that some modules are auto generated

So, we have to:

  • add change to tests (probably, revision number) - this actually seems optional
  • create second GH account that will open these PRs (to get hasFinalApproval and Merge:Auto)
  • respond to bot request to auto-merge (post Ready to merge from @Maxim-Mazurok )
@Maxim-Mazurok
Copy link
Owner Author

Maxim-Mazurok commented Aug 27, 2020

Please, welcome our bot: @google-api-typings-generator :) #281 will use this account.
Its profile picture should not conflict with Google Logos and Trademarks Usage Guidelines, because it uses a distinctly different font and color for G.
Also, it follows TS branding guidelines: we don't use TS logo in any form, just the "TypeScript Blue" color.

@Maxim-Mazurok
Copy link
Owner Author

add change to tests (probably, revision number)

Done in #339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant