TLS 1.3:finalize tls13 serialize session save and load #6123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhaoth
added
component-tls13
needs-review
yuhaoth
changed the title
ronald-cron-arm
added a commit
that referenced
this pull request
Jul 23, 2022
…save_load TLS 1.3: Add serialize session save load I can see that #6087 (comment) and #6087 (comment) are addressed in #6123. Thus I am ok to merge it as it is.
yuhaoth
force-pushed
the
pr/finialize-tls13-serialize_session_save_load
branch
from
0c26766
to
e363e22
Compare
library/ssl_tls.c
Outdated
| #endif | ||
|
|
||
| return( used ); | ||
| return( 0 ); |
There was a problem hiding this comment.
Curius as to why we setting the MBEDTLS_CHECK_RETURN_CRITICAL attribute and then returning always 0?
There was a problem hiding this comment.
MBEDTLS_SSL_CHK_BUF_PTR will return buffer too small error.
There was a problem hiding this comment.
So aligned it with the behaviour of ssl_tls13_session_save of always returning 0 and if anything fails it will be caught on the ssl_session_save. Got it thanks.
yuhaoth
force-pushed
the
pr/finialize-tls13-serialize_session_save_load
branch
from
e363e22
to
aff7737
Compare
xkqian
suggested changes
Jul 29, 2022
yuhaoth
removed
the
needs-reviewer
minosgalanakis
previously approved these changes
Aug 1, 2022
yuhaoth
force-pushed
the
pr/finialize-tls13-serialize_session_save_load
branch
from
92d73eb
to
c1d5253
Compare
|
Rebased |
xkqian
suggested changes
Aug 11, 2022
yuhaoth
added
the
approved
ronald-cron-arm
changed the title
ronald-cron-arm
requested changes
Aug 16, 2022
yuhaoth
force-pushed
the
pr/finialize-tls13-serialize_session_save_load
branch
from
cb21a0f
to
6f6030b
Compare
|
Rewrite base on @ronald-cron-arm 's comments |
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
force-pushed
the
pr/finialize-tls13-serialize_session_save_load
branch
from
6f6030b
to
e36fdd6
Compare
yuhaoth
removed
the
approved
yuhaoth
force-pushed
the
pr/finialize-tls13-serialize_session_save_load
branch
from
12f8e96
to
35b1730
Compare
From RFC 8446 and the definition of session, we should check the length. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
force-pushed
the
pr/finialize-tls13-serialize_session_save_load
branch
from
35b1730
to
5b7c7ca
Compare
ronald-cron-arm
requested changes
Aug 18, 2022
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
ronald-cron-arm
approved these changes
Aug 18, 2022
yuhaoth
added a commit
to yuhaoth/mbedtls1.3
that referenced
this pull request
Nov 26, 2022
…ialize_session_save_load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #6122
Address left comments in #6087
Status
READY
Part of adding PSK support in TLS 1.3. No need for a change log.