-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driver hashes rsa v21 #6141
Merged
Merged
Driver hashes rsa v21 #6141
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
259c213
Tune API of internal function mgf_mask in RSA
mpg f3a6755
Simplify callers of mgf_mask()
mpg f701acc
Extract common code into hash_mprime()
mpg 35c09e4
Introduce compute_hash() function
mpg faa3b4e
Get rid of md_info outside helper functions
mpg 077ba84
PKCS#1 v2.1 now builds with PSA if no MD_C
mpg 7a27e85
Fix failure of RSA accel test
mpg e741c61
Adjust dependencies in test_suite_pkcs1_v21
mpg 7d52716
Fix undeclared dependencies on SHA-1
mpg 79b99f4
Fix definition of MD_OR_PSA macros
mpg 712bb9c
Use more suitable function for checking if hash is supported
mprse 2aae040
make ret_from_status() global function and move it to has_info.[ch]
mprse f98b57f
Initialize status/ret to error value
mprse 71bf28b
Fix include file path
mprse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, there's nothing specific about MD5 here. However, I agree that we should clarify that if using MD, you also need the
MBEDTLS_xxx_C
for all the hashes you can to use, and otherwise you also needPSA_WANT_ALG_xxx
for those hashes.