Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Implement and use MBEDTLS_STATIC_ASSERT() #7319

Closed
wants to merge 1 commit into from
Closed

Backport 2.28: Implement and use MBEDTLS_STATIC_ASSERT() #7319

wants to merge 1 commit into from

Conversation

paul-elliott-arm
Copy link
Member

Description

This is a trivial backport of #7229 (in its end state)

Gatekeeper checklist

@paul-elliott-arm
Backport and use MBEDTLS_STATIC_ASSERT()
7fe1a6c 
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
@paul-elliott-arm paul-elliott-arm self-assigned this Mar 20, 2023
@paul-elliott-arm paul-elliott-arm added enhancement needs-review Every commit must be reviewed by at least two team members, component-platform Portability layer and build scripts needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review single-reviewer This PR qualifies for having only one reviewer priority-very-high Highest priority - prioritise this over other review work size-xs Estimated task size: extra small (a few hours at most) labels Mar 20, 2023
@paul-elliott-arm paul-elliott-arm added this to To Do in Roadmap Board for Mbed TLS via automation Mar 20, 2023
@paul-elliott-arm paul-elliott-arm moved this from To Do to In Review in Roadmap Board for Mbed TLS Mar 20, 2023
@paul-elliott-arm paul-elliott-arm changed the title Backport and use MBEDTLS_STATIC_ASSERT() Backport 2.28: Implement and use MBEDTLS_STATIC_ASSERT() Mar 20, 2023
minosgalanakis
minosgalanakis approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Implements static_assert in line with #7229 when present.

The functionality is not present in ssl_tls.c and and ssl_tls12_server.c` so those modifications were not brought over.

@paul-elliott-arm
Copy link
Member Author

Closing as duplicate of #7320

Roadmap Board for Mbed TLS automation moved this from In Review to Done Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minosgalanakis minosgalanakis minosgalanakis approved these changes

@daverodgman daverodgman Awaiting requested review from daverodgman

Assignees

@paul-elliott-arm paul-elliott-arm

Labels
component-platform Portability layer and build scripts enhancement needs-ci Needs to pass CI tests needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-very-high Highest priority - prioritise this over other review work single-reviewer This PR qualifies for having only one reviewer size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paul-elliott-arm @minosgalanakis