Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Implement and use MBEDTLS_STATIC_ASSERT() #7320

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Backport 2.28: Implement and use MBEDTLS_STATIC_ASSERT() #7320

merged 2 commits into from
Mar 20, 2023

Conversation

tom-cosgrove-arm
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm commented Mar 20, 2023 •
edited by daverodgman
Loading

Gatekeeper checklist

@tom-cosgrove-arm
Implement and use MBEDTLS_STATIC_ASSERT()
bdd01a7 
Fixes Mbed-TLS#3693

Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
@tom-cosgrove-arm
Have MBEDTLS_STATIC_ASSERT() match current development more closely
410594c 
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
@tom-cosgrove-arm tom-cosgrove-arm mentioned this pull request Mar 20, 2023
Merged
3 tasks
@tom-cosgrove-arm tom-cosgrove-arm added component-platform Portability layer and build scripts size-s Estimated task size: small (~2d) labels Mar 20, 2023
paul-elliott-arm
paul-elliott-arm approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@paul-elliott-arm paul-elliott-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paul-elliott-arm paul-elliott-arm added the single-reviewer This PR qualifies for having only one reviewer label Mar 20, 2023
@tom-cosgrove-arm tom-cosgrove-arm added needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review needs-review Every commit must be reviewed by at least two team members, size-xs Estimated task size: extra small (a few hours at most) enhancement priority-very-high Highest priority - prioritise this over other review work and removed size-s Estimated task size: small (~2d) labels Mar 20, 2023
@paul-elliott-arm paul-elliott-arm mentioned this pull request Mar 20, 2023
Closed
3 tasks
@daverodgman daverodgman added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Mar 20, 2023
@daverodgman
Copy link
Contributor

Windows CI issue is unrelated

@tom-cosgrove-arm
Copy link
Contributor Author

@bensze01 From TF OpenCI: PR-7320-head TLS Testing, this seems a bit of an issue:

No space left on device

@paul-elliott-arm
Copy link
Member

CI looks good apart from the Windows issues. OpenCI disk space issues have been reported to Linaro.

@paul-elliott-arm paul-elliott-arm merged commit fc28ffa into Mbed-TLS:mbedtls-2.28 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-elliott-arm paul-elliott-arm paul-elliott-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-platform Portability layer and build scripts enhancement needs-ci Needs to pass CI tests priority-very-high Highest priority - prioritise this over other review work single-reviewer This PR qualifies for having only one reviewer size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tom-cosgrove-arm @daverodgman @paul-elliott-arm