Allow install headers to different location #8795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use standard `CMAKE_INSTALL_INCLUDEDIR` and `CMAKE_INSTALL_LIBDIR` location to define headers and library installation. This variable can be redefined on configuration phase to allow install headers and libraries to different location (like `include/mbedtls2`). Additionally removing explicit permission rules as they may broke proper permissions for system installation (like remove executable bit from libraries). By default CMake sets permissions correctly on all files and directories. See Mbed-TLS#8723 for rationale. Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
winterheart
force-pushed
the
mbedtls-2.28-subslotting
branch
from
c1c1853
to
09902b2
Compare
3 tasks
tom-cosgrove-arm
added
enhancement
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use standard
CMAKE_INSTALL_INCLUDEDIRandCMAKE_INSTALL_LIBDIRlocation to define headers and library installation. This variable can be redefined on configuration phase to allow install headers and libraries to different location (likeinclude/mbedtls2, #8723).See #8723 for rationale.
Fixes #8723
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")