Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow install headers to different location (mbedtls-3) #8800

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Allow install headers to different location (mbedtls-3) #8800

wants to merge 1 commit into from

Conversation

winterheart
Copy link

@winterheart winterheart commented Feb 7, 2024 •
edited by tom-cosgrove-arm

Description

Use standard CMAKE_INSTALL_INCLUDEDIR and CMAKE_INSTALL_LIBDIR location to define headers and library installation. This variable can be redefined on configuration phase to allow install headers and libraries to different location (like include/mbedtls3, #8723).

Additionally removing explicit permission rules as they may broke proper permissions for system installation (like remove executable bit from libraries). By default CMake sets permissions correctly on all files and directories.

See #8723 for rationale.

Fixes #8723

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@winterheart
Allow install headers to different location
47b137e 
Use standard `CMAKE_INSTALL_INCLUDEDIR` and `CMAKE_INSTALL_LIBDIR`
location to define headers and library installation. This variable can be
redefined on configuration phase to allow install headers and libraries to
different location (like `include/mbedtls3`, Mbed-TLS#8723).

Additionally removing explicit permission rules as they may broke proper
permissions for system installation (like remove executable bit from
libraries). By default CMake sets permissions correctly on all files and
directories.

See Mbed-TLS#8723 for rationale.

Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
@tom-cosgrove-arm tom-cosgrove-arm mentioned this pull request Feb 8, 2024
Open
3 tasks
@tom-cosgrove-arm tom-cosgrove-arm added enhancement needs-review Every commit must be reviewed by at least two team members, component-platform Portability layer and build scripts needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits needs-backports Backports are missing or are pending review and approval. labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component-platform Portability layer and build scripts enhancement needs-backports Backports are missing or are pending review and approval. needs-ci Needs to pass CI tests needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to install multiple versions (2.*, 3.*, 4.* ...) on the system simultaneously
2 participants
@winterheart @tom-cosgrove-arm