Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MBEDTLS_MD_CAN_SHA224 with PSA_WANT_ALG_SHA_224 #9170

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Replace MBEDTLS_MD_CAN_SHA224 with PSA_WANT_ALG_SHA_224 #9170

merged 2 commits into from
Jul 3, 2024

Conversation

eleuzi01
Copy link
Contributor

@eleuzi01 eleuzi01 commented May 23, 2024 •
edited
Loading

Description

Issue #9111

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog not required, internal changes
  • 3.6 backport not required, needed for 4.0
  • 2.28 backport not required, needed for 4.0
  • tests not required

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@eleuzi01 eleuzi01 self-assigned this May 23, 2024
@eleuzi01 eleuzi01 added enhancement component-crypto Crypto primitives and low-level interfaces labels May 23, 2024
@eleuzi01 eleuzi01 added size-m Estimated task size: medium (~1w) size-s Estimated task size: small (~2d) and removed size-m Estimated task size: medium (~1w) labels May 31, 2024
@gabor-mezei-arm gabor-mezei-arm linked an issue Jun 5, 2024 that may be closed by this pull request
Replace MBEDTLS_MD_CAN_SHA224 with its PSA_WANT counterpartart #9111
Closed
@gabor-mezei-arm gabor-mezei-arm added the needs-preceding-pr Requires another PR to be merged first label Jun 5, 2024
@eleuzi01 eleuzi01 added needs-ci Needs to pass CI tests priority-high High priority - will be reviewed soon labels Jun 13, 2024
@eleuzi01 eleuzi01 force-pushed the replace-mbedtls-md-can-sha224 branch from 124c529 to dfa1343 Compare June 20, 2024 15:39
@eleuzi01 eleuzi01 added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-preceding-pr Requires another PR to be merged first labels Jun 20, 2024
@gabor-mezei-arm gabor-mezei-arm self-requested a review June 20, 2024 16:07
@eleuzi01 eleuzi01 removed the needs-ci Needs to pass CI tests label Jun 24, 2024
gabor-mezei-arm
gabor-mezei-arm requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This occurrence also should be replaced:

mbedtls/include/mbedtls/md.h

Line 76 in dfa1343

#elif defined(MBEDTLS_MD_CAN_SHA224) || defined(MBEDTLS_MD_CAN_SHA3_224)

@eleuzi01
Copy link
Contributor Author

This occurrence also should be replaced:

mbedtls/include/mbedtls/md.h

Line 76 in dfa1343

#elif defined(MBEDTLS_MD_CAN_SHA224) || defined(MBEDTLS_MD_CAN_SHA3_224)

@gabor-mezei-arm in the issue description it said replace everywhere except in the include directory. Is this an exception, or should I also replace MBEDTLS_MD_CAN_SHA224 in the include directory as well?

@gabor-mezei-arm
Copy link
Contributor

It seems the md.h is an exception. The others don't need to be changed.

gabor-mezei-arm
gabor-mezei-arm previously approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eleuzi01
Replace MBEDTLS_MD_CAN_SHA224 with PSA_WANT_ALG_SHA_224
fcc9afa 
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
@eleuzi01
Replace MBEDTLS_MD_CAN_SHA224 in md.h
6244882 
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
@eleuzi01 eleuzi01 force-pushed the replace-mbedtls-md-can-sha224 branch from ca800f5 to 6244882 Compare July 2, 2024 10:35
gabor-mezei-arm
gabor-mezei-arm approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-daubney-arm tom-daubney-arm self-requested a review July 2, 2024 19:05
@tom-daubney-arm tom-daubney-arm removed the needs-reviewer This PR needs someone to pick it up for review label Jul 2, 2024
tom-daubney-arm
tom-daubney-arm approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@tom-daubney-arm tom-daubney-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Jul 2, 2024
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Jul 3, 2024
Merged via the queue into Mbed-TLS:development with commit 4a17523 Jul 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabor-mezei-arm gabor-mezei-arm gabor-mezei-arm approved these changes

@tom-daubney-arm tom-daubney-arm tom-daubney-arm approved these changes

Assignees

@eleuzi01 eleuzi01

Labels
approved Design and code approved - may be waiting for CI or backports component-crypto Crypto primitives and low-level interfaces enhancement priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Roadmap Board for Mbed TLS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace MBEDTLS_MD_CAN_SHA224 with its PSA_WANT counterpartart
4 participants
@eleuzi01 @gabor-mezei-arm @tom-daubney-arm @gilles-peskine-arm