-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error warning log pollution + composer recipes (Part 3) #100
Conversation
cc2c73c
to
558c2ab
Compare
This reverts commit feaa9a8.
… level. Enable full stracktrace in dev mode
…he pros when you're a developer
886c2bb
to
0982da1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
I got this info/warning during the migration step, is this expected?
|
Also, my |
Ps. Sorry about 30 commits. I can rewrite git history if you wish. Then again we will use squash merge so it will be a single commit anyway.. |
Ow that is maybe not cool.. I did enable log rotation. But it shouldn't spam that much to prod.log. Dev.log is a different story of course. Let me check |
Is the deprecation message pointing to a file in our code base? I don't think so? |
it looks like you also axed so now it would just log all that's enabled |
Good point... just pointing out the obvious if you will. Doesn't bother me if it doesn't bother you. |
It was not very well documented on https://symfony.com/doc/current/logging.html#how-to-rotate-your-log-files, but we now use This last config allows people to run development mode on a federated instance without worrying to get a 100GB dev.log files (I have been there.. done that 😢 ). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I see anything particularly standing out, and all seems to be looking fine. @nobodyatroot ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, no more exploding logfile size!
sorry about that ^^ I made it worse instead of better. But now it should be even better than before. |
debug
toinfo
, with a remark the developer can always enabledebug
. Warning:debug
is very very verbose, henceinfo
as default.