Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove height 100% from label class in settings #150

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Oct 28, 2023

Fixes: #148

Before:

image

After:

image

Ps. Yes this is WebKit under Linux.

@melroy89 melroy89 added the frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end label Oct 28, 2023
@simonrcodrington
Copy link
Contributor

I'll approve this one. I haven't ran across it on both chrome + Firefox on Ubuntu but it seems like a simple fix. Might need to keep an eye open to see if anyone reports an issue once this one gets merged (no idea why the 100% was even in there)

@melroy89 melroy89 merged commit 8cbe26a into main Oct 28, 2023
5 checks passed
@melroy89 melroy89 deleted the fix_webkit_settings_rendering branch October 28, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings menu doesn’t display properly on IOS mobile
2 participants