Remove the translations to lower. #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melroy89
added
enhancement
melroy89
requested review from
simonrcodrington,
vintprox,
nobodyatroot and
e-five256
|
Translations that did not yet start with a capital letter is done in this PR: #188 |
|
I agree it looks better with the caps. It's a purely aesthetic approval |
Well yes, but it was a pre-requirement for introducing my new link in the drop-down menu, can I couldn't take the low caps anymore. See PR: #190 |
nobodyatroot
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I personally never liked the lower-caps in all the text. This will remove the "to lower" twig pipe from the translation strings.
I kept lower caps in notification area however as well as in some special form row segments and alt text on images.
Before:
After:
After:
After:
After:
After:
After:
Example of UNchanged lower-caps in notification page (I did keep the low caps here):