Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Open URL link to thread/post/comment #190

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Nov 1, 2023

The "Copy" link is nice, but users including myself also want to open the original link sometimes directly into a new window (yes you can use middle mouse button click, if you have that).

  • Introducing a Open URL menu item
  • Reorder the menu items
  • Introducing a separator

image

And when there is no edit, no actor and no moderator, it looks like this:

image

In another PR I might also want to automatically close the drop-down menu when a user clicked on "Copy ... URL".

TheVillageGuy
TheVillageGuy previously approved these changes Nov 1, 2023
@e-five256
Copy link
Member

e-five256 commented Nov 1, 2023

I'm wondering if the more drop down is getting a bit bloated with too many options. An alternative could be something like Original URL (Copy) (Open). But that might be a little difficult to hit on mobile screens 🤔

Edit: Looking at mastodon, it is two different options in the drop down, so maybe being consistent with them is better, or maybe other options can be moved out some other time

@melroy89
Copy link
Member Author

melroy89 commented Nov 1, 2023

I'm wondering if the more drop down is getting a bit bloated with too many options. An alternative could be something like Original URL (Copy) (Open). But that might be a little difficult to hit on mobile screens 🤔

Edit: Looking at mastodon, it is two different options in the drop down, so maybe being consistent with them is better, or maybe other options can be moved out some other time

Fair points. Yes, you are right Mastodon also does this in a similar way. I could add maybe some horizontal lines for better readability? Something that Mastodon also does (Better a good steal than a bad idea, right?)

@melroy89
Copy link
Member Author

melroy89 commented Nov 1, 2023

Reordered the menu items to make it more logical for me and it's also matching Mastodon more.

@melroy89 melroy89 merged commit ea35b53 into main Nov 1, 2023
6 checks passed
@melroy89 melroy89 deleted the add_open_link branch November 1, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants