Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit where to shown the user box in sidebar #227

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Nov 9, 2023

  • Limit where the user info box is shown in the right sidebar

@nobodyatroot nobodyatroot added the frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end label Nov 9, 2023
@e-five256
Copy link
Member

e-five256 commented Nov 9, 2023

this change makes it so the avatar does not appear on user (non-settings) pages as it previously was, as the avatar now appears in the main content box for overview / threads/ comments etc (this is on a user threads page)

image

on your own settings page, the box appears with the avatar, as it isn't present elsewhere on the page (applies to all user settings pages general / profile / email etc. in kbin it only appeared on the statistics page, I think it's useful on all of them)

(edit: ok I lied it does appear twice on user settings profile sub page, but we discussed and felt being consistent in the UI is more important than it being repeated once. it would be odd if you were swapping between general, email, password, then you click profile and suddenly the sidebar layout changes, can always change if desired)

image

no longer appears in sidebar in thread view

image

@melroy89
Copy link
Member Author

melroy89 commented Nov 9, 2023

I can't approve my own PR. so you need to approve your own changes now xD

@melroy89 melroy89 merged commit 2187a68 into main Nov 9, 2023
7 checks passed
@melroy89 melroy89 deleted the hide_user_in_sidebar branch November 9, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants