-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image cache resolve 302 #267
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
a9a239e
to
176d65e
Compare
I restored to default back to 302 to avoid issues with devenv or Docker or Caddy. However, I did add this option/setting to the configuration + inline comment in the yaml file + admin guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues from what I can tell, testing live on kbin.run and everything appears normal.
default_filter_set_settings
level, so no need to repeat it infilter_sets
.composer update
Before (302, not getting cached):
After (301, getting cached by the browser, Firefox):
EDIT: Tested live on https://kbin.melroy.org for more than 24 hours in the past already with
301
behind nginx, without any issues :)