Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image cache resolve 302 #267

Merged
merged 9 commits into from
Nov 18, 2023
Merged

Fix image cache resolve 302 #267

merged 9 commits into from
Nov 18, 2023

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Nov 15, 2023

  • Keep 302 (== default) to avoid breaking dev env or Docker setup.
  • Explain you can set this value to 301 if you are behind Nginx (assuming it's correctly configured)
    • Update docs
  • Reorder liip config
  • Add some defaults. Incl. 90 quality on default_filter_set_settings level, so no need to repeat it in filter_sets.
  • Update liip package
  • composer update

Before (302, not getting cached):

image

After (301, getting cached by the browser, Firefox):

image

EDIT: Tested live on https://kbin.melroy.org for more than 24 hours in the past already with 301 behind nginx, without any issues :)

@melroy89 melroy89 added enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end documentation Improvements or additions to documentation backend Backend related issues and pull requests labels Nov 15, 2023
@melroy89

This comment was marked as outdated.

@melroy89

This comment was marked as off-topic.

@melroy89 melroy89 removed the documentation Improvements or additions to documentation label Nov 15, 2023
@melroy89
Copy link
Member Author

melroy89 commented Nov 17, 2023

I restored to default back to 302 to avoid issues with devenv or Docker or Caddy. However, I did add this option/setting to the configuration + inline comment in the yaml file + admin guide documentation.

nobodyatroot
nobodyatroot previously approved these changes Nov 18, 2023
@nobodyatroot nobodyatroot self-requested a review November 18, 2023 01:46
Copy link
Member

@nobodyatroot nobodyatroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues from what I can tell, testing live on kbin.run and everything appears normal.

@melroy89 melroy89 merged commit fd07b6f into main Nov 18, 2023
7 checks passed
@melroy89 melroy89 deleted the fix_cache_resolve_302 branch November 18, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues and pull requests enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants