fix blurhash function to handle long horizontal image strip #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apparently the blurhash encoder could fail when operating on long horizontal image strip, because the internal image scaling for encoder input could results in an image with height less that 1 given max width the internal image scaling will now attempt to scale with minimum image height capped at the value of blurhash's y component when this condition is met
melroy89
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apparently the blurhash encoder could fail when operating on long horizontal image strip, because the internal image scaling for encoder input could results in an image with height less that 1 given max width
the internal image scaling will now attempt to scale with minimum image height capped at the value of blurhash's y component when this condition is met