Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error pollution on null $user object #627

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Fix error pollution on null $user object #627

merged 3 commits into from
Mar 25, 2024

Conversation

melroy89
Copy link
Member

Add missing $user check on possible empty/null object. Causing errors:

{"message":"Warning: Attempt to read property \"apFetchedAt\" on null","context":{"exception":{"class":"ErrorException","message":"Warning: Attempt to read property \"apFetchedAt\" on null","code":0,"file":"/var/www/kbin.melroy.org/html/src/Service/ActivityPubManager.php:133"}},"level":300,"level_name":"WARNING","channel":"php","datetime":"2024-03-25T00:47:01.732142+01:00","extra":{}}

@melroy89 melroy89 added enhancement New feature or request backend Backend related issues and pull requests labels Mar 25, 2024
@melroy89 melroy89 added this to the v1.5.0 milestone Mar 25, 2024
@melroy89 melroy89 requested review from BentiGorlich and a user March 25, 2024 00:17
melroy89 referenced this pull request Mar 25, 2024
@BentiGorlich @e-five256
Rework account deletion (#522)
da533e6 
Co-authored-by: debounced <35878315+nobodyatroot@users.noreply.github.com>
Co-authored-by: e-five <146029455+e-five256@users.noreply.github.com>
ghost

This comment was marked as outdated.

Sign in to view

@ghost ghost dismissed their stale review March 25, 2024 00:45

Possible impact to control flow, needs more input

@melroy89 melroy89 merged commit 6e899c7 into main Mar 25, 2024
7 checks passed
@melroy89 melroy89 deleted the fix_error_pollution branch March 25, 2024 11:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BentiGorlich BentiGorlich BentiGorlich approved these changes

Assignees
No one assigned
Labels
backend Backend related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@melroy89 @BentiGorlich