Fix some API calls #681
Merged
Fix some API calls #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `DomainRetrieveApi` asserted the wrong type - `SearchRetrieveAPI` was missing the querying user parameter - `EntryResponseDto` did not handle nulls on the `domain` property - `MagazineResponseDto` did not handle nulls on the `owner` property - `UserRepository` was missing a parameter and the query was not exactly right
BentiGorlich
added
bug
ghost
approved these changes
Apr 7, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DomainRetrieveApiasserted the wrong typeSearchRetrieveAPIwas missing the querying user parameterEntryResponseDtodid not handle nulls on thedomainpropertyMagazineResponseDtodid not handle nulls on theownerpropertyUserRepositorywas missing a parameter and the query was not exactly rightI found a few bugs in the API while working on #654