Implement rules federation, fix markdown federation #694
Conversation
- the summary of magazines includes the markdown source now - the summary of magazines includes the rules now - when updating a magazine the markdown source is used if available and if the last header includes "rules" it will be put in the rules field - the summary actually works now. Before it would output the markdown as the summary and we would assume that the summary field is an html field, so we would try to convert html -> markdown, except that the html we tried to convert already was markdown, so it just didn't work properly
BentiGorlich
added
bug
|
I observed the problem especially while looking at https://gehirneimer.de/m/FloatingIsFun@fedia.io vs https://fedia.io/m/FloatingIsFun |
src/Service/ActivityPubManager.php
Outdated
| public function extractRules(string &$description): ?string | ||
| { | ||
| $lines = explode("\n", $description); | ||
| $headers = []; | ||
| $i = 0; | ||
| foreach ($lines as $line) { | ||
| if (preg_match("/^#+ ([^\n\r]*)/", $line, $matches)) { | ||
| if (2 === \sizeof($matches)) { | ||
| $headers[] = ['line' => $i, 'header' => $matches[1]]; | ||
| } | ||
| } | ||
| ++$i; | ||
| } | ||
|
|
||
| $rules = null; | ||
|
|
||
| if (!empty($headers)) { | ||
| $lastHeader = $headers[\sizeof($headers) - 1]; | ||
| if (str_contains(strtolower($lastHeader['header']), 'rules')) { | ||
| $descLines = \array_slice($lines, 0, $lastHeader['line']); | ||
| $ruleLines = \array_slice($lines, $lastHeader['line'] + 1, \sizeof($lines) - $lastHeader['line']); | ||
| $description = join("\n", $descLines); | ||
| $rules = join("\n", $ruleLines); | ||
| } | ||
| } | ||
|
|
||
| return $rules; | ||
| } |
There was a problem hiding this comment.
I just don't think this is a good idea vs parsing it as a regular description like we've been doing, it seems way too prone to failure. For instance a random remote magazine might have a quote in its description like ## “Know the rules well, so you can break them effectively.” - Dalai Lama XIV we suddenly parse that as the rules. Also, it doesn't work for non-english, so is flaky
There was a problem hiding this comment.
Before thinking to hard about this what do you think about my ideas for the rules field? Because if you think it is too complicated and not really worth it then we will just deprecate the field (if everyone agrees)
There was a problem hiding this comment.
I think it's fine to keep it if you see value
My opinions on keeping it would be:
- Add it as "Rules" as you have now on outgoing
- Remove this extract rules from remote, just keep it all in description for now, even from other mbin instances
- Make an FEP for something like adding a rules field ordered list to group actors, if that's what you think works better
|
I'm sorry for being a bit late to the party, but isn't this related to a feature request I made a while ago asking for local and external description/rules. I'm having a bit of a hard time grasping what exactly you're handling here so can't say whether I agree or not |
|
If I remove the dev / AP specific jargon, I did the following:
The "parsing" will most likely be removed |
|
i vote for whatever gives us the most/best compatibility across the fediverse :-) |
Closes #415