fix mercure eventsource (re)connection explosion in firefox #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, the firefox bug workaround in eventsource mercure connection code would results in a new untracked connection to mercure and there would be a new untracked connection everytime initial mercure eventsource connection onerror handler activated. try idling on any page while using dev tools to track network requests to mercure and observe an additional request to mercure everytime the current one terminates approx. every 10m
This comment was marked as outdated.
This comment was marked as outdated.
melroy89
reviewed
Oct 19, 2023
Co-authored-by: Melroy van den Berg <melroy@melroy.org>
melroy89
approved these changes
Oct 19, 2023
|
@asdfzdfj If Mercure is down for whatever reason or wrongly configured by the server admin.. Firefox is spamming like hell:
Shouldn't we implement some |
melroy89
added
documentation
asdfzdfj
added a commit
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, the firefox bug workaround in eventsource mercure connection code would results in a new untracked connection to mercure and there would be a new untracked connection everytime the initial mercure eventsource connection onerror handler is triggered.
try idling on any page while using dev tools open to track network requests to mercure and observe an additional request to mercure everytime the current one terminates approx. every 10m
although from some quick testing against newer/current firefox version, it looks like this workaround might not be needed and perhaps can be removed entirely? (last I checked was with FF 116 and it seemed to work fine)